-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: accessibility - color contrast and keyboard navigation #6757
fix: accessibility - color contrast and keyboard navigation #6757
Conversation
color contrast, keyboard navigation, and label updates
✅ Deploy Preview for decap-www ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @kewitham thanks for this contribution. This product supports many languages, so aria labels should be translated also. I also don't understand why the Russian translation was modified, perhaps it's just a merge issue? |
@martinjagodic The Russian translation updates are just formatting updates. Do you have an internal resource for translating the aria labels? What are the next steps there? |
It would be nice if this is split into multiple PRs which encompass logical areas of the changes. I don't have a firm opinion on how to structure this, but first I would recommend moving the formatting of russian translations to separate PR. Also separate PR: aria labels should be split from minor accessibility improvements. That's because currently they need to be translated. |
@samo4 @martinjagodic I have removed the aria label updates and formatting updates from this PR. I will submit another one with just the aria updates |
@samo4 @martinjagodic checking back in on this PR - is it good to merge now? |
@demshy since you're working on updating the markdown editor, is this PR conflicting with your efforts? |
Some of it for sure, because we had to basically rewrite all keyboard events. I don't mind if this is merged though. I will make sure the escape key is handled properly in the new handlers. |
* fix: accessibility color contrast, keyboard navigation, and label updates * Update ViewStyleControl.js * Update EditorControl.js * Update MediaLibraryHeader.js * Update SettingsDropdown.js * Update ObjectWidgetTopBar.js * Update Toolbar.js * Update ListControl.spec.js.snap * Update DateTimeControl.js * Update DateTimeControl.js * Update DateTimeControl.js * Update MediaLibraryCard.spec.js.snap * Update index.js
* fix: accessibility color contrast, keyboard navigation, and label updates * Update ViewStyleControl.js * Update EditorControl.js * Update MediaLibraryHeader.js * Update SettingsDropdown.js * Update ObjectWidgetTopBar.js * Update Toolbar.js * Update ListControl.spec.js.snap * Update DateTimeControl.js * Update DateTimeControl.js * Update DateTimeControl.js * Update MediaLibraryCard.spec.js.snap * Update index.js
…#6757) * fix: accessibility color contrast, keyboard navigation, and label updates * Update ViewStyleControl.js * Update EditorControl.js * Update MediaLibraryHeader.js * Update SettingsDropdown.js * Update ObjectWidgetTopBar.js * Update Toolbar.js * Update ListControl.spec.js.snap * Update DateTimeControl.js * Update DateTimeControl.js * Update DateTimeControl.js * Update MediaLibraryCard.spec.js.snap * Update index.js
Summary
Our team at ada.gov uses Netlify CMS. Recently Terri Youngblood, the accessibility consultant for the DOJ Civil Rights Section, did an audit of Netlify to verify its accessibility and identified some issues. This PR addresses those concerns - specifically color contrast, and keyboard navigation updates.
Test plan
i.e.
Before
After
Note: I used this tool to darken the colors in question until they met the minimum contrast requirements.
Checklist
Please add a
x
inside each checkbox:A picture of a cute animal (not mandatory but encouraged)