Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netlify-cms doesn't pass @netlify/plugin-a11y test #6061

Closed
jsjoeio opened this issue Dec 18, 2021 · 6 comments
Closed

netlify-cms doesn't pass @netlify/plugin-a11y test #6061

jsjoeio opened this issue Dec 18, 2021 · 6 comments
Labels
area: accessibility good first issue type: bug code to address defects in shipped code

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 18, 2021

Describe the bug
The "Login with Netlify" button does not have sufficient contrast.

Error: Elements must have 
sufficient
 color contrast (https://dequeuniversity.com/rules/axe/4.3/color-contrast?application=axeAPI)
10:53:25 PM:  ├── color-contrast
10:53:25 PM:  ├── #nc-root > div > section > button
10:53:25 PM:  └── <button class="css-tu1it6-LoginButton-button-default-gray-disabled e4hp3ji4">Login with Netlify Identity</button>

To Reproduce

  1. Add Netlify CMS to any site
  2. Add package = "@netlify/plugin-a11y" to nelify.toml
  3. Deploy site to Netlify

Expected behavior
netlify-cms should pass @netlify/plugin-a11y test 😅

Screenshots
image

Applicable Versions:

  • Netlify CMS version: 2.0.0
  • Git provider: GitHub
  • OS: Windows 10
  • Browser version [e.g. chrome 22, safari 11]
  • Node.JS version:

CMS configuration
N/A

Additional context
Possible duplicate of #1333

@jsjoeio jsjoeio added the type: bug code to address defects in shipped code label Dec 18, 2021
@erezrokah
Copy link
Contributor

erezrokah commented Dec 20, 2021

Thanks for putting this together @jsjoeio!

Do you mind adding this to #1333 so we can have a centralized place to handle accessibility related issues?

The CMS is a community project, so it would be great to see some contributions around this.
I labeled this issue and #1333 and good first issue to help with that.

Also I think 8a14937fcc7167ae5a7960a692e8054c/packages/netlify-cms-ui-default/src/AuthenticationPage.js#L94 it is a good place to start

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 20, 2021

Do you mind adding this to #1333 so we can have a centralized place to handle accessibility related issues?

Sure, I'll do that now!

The CMS is a community project

Ah, for some reason, I assumed since it's under the netlify org/namespace that they maintained it. Good to know!

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 20, 2021

Closing in favor of #1333 (comment)

@jsjoeio jsjoeio closed this as completed Dec 20, 2021
@erezrokah
Copy link
Contributor

Ah, for some reason, I assumed since it's under the netlify org/namespace that they maintained it. Good to know!

We (Netlify) have dedicated resources for it (I'm one of those resources, 👋) which are targeted to support contributions.
I hope that helps clarifying my initial comment.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 20, 2021

We (Netlify) have dedicated resources for it (I'm one of those resources, 👋) which are targeted to support contributions.
I hope that helps clarifying my initial comment.

Ah, I misunderstood. I thought you were a person from the community volunteering to run the project in your free time on behalf of Netlify 😅 Thanks for clarifying!

Another question came to mind. How do we (the community) know what issues you (the maintainers) are prioritizing? I peeked in the milestones and projects but don't see those being used. Just curious in case I run into other issues.

@erezrokah
Copy link
Contributor

Hi @jsjoeio, any active work is done by external contributors, either by picking good first issues, or by looking at most upvoted issues.

As maintainers we focus on reviewing PRs that come in and guiding people in resolving issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: accessibility good first issue type: bug code to address defects in shipped code
Projects
None yet
Development

No branches or pull requests

2 participants