Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Gallery includes dotfiles in Preview #5596

Open
madsem opened this issue Jul 8, 2021 · 5 comments
Open

Media Gallery includes dotfiles in Preview #5596

madsem opened this issue Jul 8, 2021 · 5 comments
Labels
area: media-library good first issue type: bug code to address defects in shipped code

Comments

@madsem
Copy link

madsem commented Jul 8, 2021

I just created a directory for the media library, because it's empty I added a .gitkeep in the directory.

Expected behavior would have been to not see this file in the Media Library UI, but it shows up as transparent image.

Screen Shot 2021-07-08 at 4 32 33 PM

@madsem madsem added the type: bug code to address defects in shipped code label Jul 8, 2021
@DenysLins
Copy link

Can I work on this issue @erezrokah ?

@DenysLins
Copy link

DenysLins commented Jul 9, 2021

Hi @erezrokah, I have some doubts about this issue:

  1. We must allow the user to upload non-image files through the OS Open screen?
  2. The user can push non-image files directly to the media folder in the repository. In this case, we must hide all non-images when listing in the media screen or only files started with a dot, as in the issue description?

@erezrokah
Copy link
Contributor

erezrokah commented Jul 11, 2021

Hi @DenysLins, I think we can add an option to configure exclude patterns. The default exclude patterns will be to hide files starting with a dot.
Users could configure it similar to https://www.netlifycms.org/docs/beta-features/#image-widget-file-size-limit
WDYT?

@DenysLins
Copy link

Sure... I will work on that...

@jwktje
Copy link

jwktje commented Feb 3, 2022

Any update on this, or a way I could help with this? I'm having the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: media-library good first issue type: bug code to address defects in shipped code
Projects
None yet
Development

No branches or pull requests

4 participants