Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New page" button shouldn't show for collections that it doesn't work for #4255

Open
kaganjd opened this issue Sep 5, 2020 · 1 comment
Open
Labels
area: configuration area: ui/collection type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@kaganjd
Copy link

kaganjd commented Sep 5, 2020

Is your feature request related to a problem? Please describe.
In the Netlify forum, someone was trying to use "New page" on a file collection. Clicking the button returned a blank page. This is by design, not an error, but maybe we could make this more intuitive for people.

Describe the solution you'd like
Don't show "New page" button on collection types it won't work for.

Additional context
https://community.netlify.com/t/click-new-page-shows-empty-page/21337/5

@kaganjd kaganjd added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Sep 5, 2020
@erezrokah
Copy link
Contributor

Thanks @kaganjd, since the create: true option is opt in for folder collections, we could probably prevent users setting it for file collections during schema validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: configuration area: ui/collection type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

No branches or pull requests

2 participants