Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Media Folder for File and Images Widget #2794

Closed
mateuswetah opened this issue Oct 24, 2019 · 2 comments
Closed

Separate Media Folder for File and Images Widget #2794

mateuswetah opened this issue Oct 24, 2019 · 2 comments

Comments

@mateuswetah
Copy link

Is your feature request related to a problem? Please describe.
I know there is a lot of discussion regarding folder organization of media files (#513, #1046, #1472)... But the solution that people have been proposing of having media folders relative to collections may not be enough. I some cases you may want widget-level folder structure.

Describe the solution you'd like
I would like to be able to configure images and file widgets with different folders. The reason for that is that I want to put my images on an Assets folder, that is handled every time by optimization scripts, and the rest of the files, such as PDFs, could go on a Static folder.

Describe alternatives you've considered
I might be choosing the harder path here, maybe it should be on Webpack's shoulder to deal with the necessary image file types and the rest could be ignored... Also, I have just received this recomendation.

@jeromecoupe
Copy link

jeromecoupe commented Nov 5, 2019

For most of my projects, a single folder for all assets / images is what is keeping me from going fully git-based. I think that the widget level approach might be a good one. I am no React dev but here are my 2 cents:

  • keep media_folder and public_folder as general config option so we keep one central location for all assets
  • allow media_subfolder_path and media_subfolder_url as config options per file or image widget that would be concatenated with the general config options

That would

  • preserve the current behaviour
  • keep everything in a centralised location which is easier to browse and make sense of for users
  • give developers a lot more flexibility.

@erezrokah
Copy link
Contributor

Should be fixed with #3208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants