-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer works with uglify-js #610
Comments
It is intentional. Uglify is outdated doesn't work on ES6 code. Use |
Anyway, are you aware that |
Check the package readme for
It uses terser, pretty plainly indicated at the top of their readme. |
Thanks, didn't check that. Anyway, as said above, expect lot of complains from webpack users. |
Also,
Are you aware that babel exists and is a standard tool to compile ES6+ code to ES5 and pretty seamlessly interops with weboack, rollup, parcel and a slew of other bundlers that could have been easily researched with a Google search instead of yelling at a package maintainer? 😉 |
Sure, I know babel. I also know that default webpack configuration (that which is widely used) does not convert Just a reference: vercel/next.js#3564 |
@ibc I used to work at ZEIT. We used Babel very effectively where needed. You don't want your entire node_modules compiled because that would be silly. Further, modules providing a transpiled version is unsustainable. Please read vercel/next.js#3564 (comment) as he is pretty objectively correct. I won't discuss this issue any more as the decision has been made to follow current best practices. I suggest researching further as there are leagues of prose on this matter available to you through various searches. This is where the JavaScript ecosystem is headed and has already been adopted pretty much everywhere else. Debug will not be transpiling code any longer except for browser versions, which I'm looking into deprecating as well. |
I think that, due this commit
debug
no longer works withbrowserify
+gulp-uglify
(which usesuglify-js
internally):If I use
browserify
withoutuglify
and check the generated bundled JS file, it contains:I don't think this is intentional, am I right?
The text was updated successfully, but these errors were encountered: