Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue fixed about Markup #5

Open
eanon opened this issue May 26, 2023 · 1 comment
Open

Issue fixed about Markup #5

eanon opened this issue May 26, 2023 · 1 comment

Comments

@eanon
Copy link

eanon commented May 26, 2023

Trying Flask-Modals today (through the BS5 example), I got an error indicating missing Markup. So, I fixed it removing any version mention in requirements.txt to get all last ones, and changing modal.py as follow:

# from jinja2.utils import markupsafe
from markupsafe import Markup

# return markupsafe.Markup(render_template('modals/modalMessages.html'))
return Markup(render_template('modals/modalMessages.html'))

However, nice. Bravo!

@mobone
Copy link

mobone commented Oct 31, 2023

I concur. I changed line 113 to html = markupsafe.Markup(nprogress_html + main_html) in modal.py. A few different ways to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants