Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't apply shadow styling to SortRow on iOS #126

Closed
jd20 opened this issue Dec 3, 2017 · 2 comments
Closed

Can't apply shadow styling to SortRow on iOS #126

jd20 opened this issue Dec 3, 2017 · 2 comments

Comments

@jd20
Copy link

jd20 commented Dec 3, 2017

Attempting to apply a shadow to the active row using sortRowStyle prop doesn't seem possible. The shadow simply doesn't appear. If I remove the overflow: 'hidden' from SortRow's base style, the shadow does appear, so I suspect this is an iOS/RN issue (seems described here: facebook/react-native#449).

Any particular reason for the overflow: hidden? Would it be better to leave it off the base style, and let the end user pass it via sortRowStyle if needed? I can submit a PR if you'd like, it's a simple one-liner.

@nihgwu
Copy link
Collaborator

nihgwu commented Dec 3, 2017

I don't know why overflow: hidden is there, but you can just override it in your sortRowStyle with overflow: visible

@jd20
Copy link
Author

jd20 commented Dec 3, 2017

Ah, good point, no need to modify the original base style.

@nihgwu nihgwu closed this as completed Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants