Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic output #81

Open
jyn514 opened this issue Oct 22, 2020 · 0 comments
Open

Deterministic output #81

jyn514 opened this issue Oct 22, 2020 · 0 comments
Labels
C-enhancement Category: This is a new feature
Milestone

Comments

@jyn514
Copy link
Contributor

jyn514 commented Oct 22, 2020

#74 fixed #56 in the sense that now all errors are always reported. However, the order of the errors is non-deterministic because deadlinks uses walkdir and rayon, which are non-deterministic.

Ordering errors within a file will probably not be too difficult - it will require checking the whole file before reporting errors, but since individual files don't take long to check I don't forsee much of a problem there. The tricky thing will be ordering the files themselves - a naive 'run all checks, then report all errors' will greatly slow down the time before the first report, because file directories can be (and often are) deeply nested.

cc @martin-t

@jyn514 jyn514 added the C-enhancement Category: This is a new feature label Oct 22, 2020
@jyn514 jyn514 added this to the 1.0 milestone Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: This is a new feature
Projects
None yet
Development

No branches or pull requests

1 participant