Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong terminal location when fullscreen application is focused #239

Open
TheRealGramdalf opened this issue Nov 10, 2022 · 5 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@TheRealGramdalf
Copy link

TheRealGramdalf commented Nov 10, 2022

When using the terminal when another application is in full screen, the terminal starts from the lowest position of where the top bar would be. (see pictures)

Regular (non fullscreen)
image

In fullscreen
image

Ideally, the terminal would start from the top pixel of the screen if the focused application is in fullscreen (like in the second picture), but from beneath the top bar when the focused application is not (as in the first picture).

Some extra logic would be required, but that's the basic issue.

I tested this while disabling all other extensions, so I'm reasonably sure that it's not to do with another extension interfering. Distro is fedora 36 (gnome 42.4), using x11 (due to some issues with nvidia+wayland),

Also I realized that perhaps the screenshot I used wasn't the best example, hopefully you see what I mean though.

@amezin amezin self-assigned this Nov 16, 2022
@amezin amezin added the bug Something isn't working label Nov 16, 2022
@amezin
Copy link
Member

amezin commented Nov 16, 2022

Yes, I understand and I am able to reproduce the issue.
I rarely use fullscreen mode - that's why this issue was unnoticed for so long.

@TheRealGramdalf
Copy link
Author

Yeah, it's definitely not super common. I run an MC server so I'll have the game in fullscreen and use the terminal to look at logs at the same time. Kinda niche, so it's totally understandable as to why you didn't know. It's not super urgent, as it's purely aesthetic, so take your time! In the mean time, I'll continue to enjoy your amazing plugin.

@amezin
Copy link
Member

amezin commented Nov 23, 2022

Unfortunately, it seems that GNOME Shell doesn't allow moving windows to locations overlapping the panel. Even if there's a fullscreen window. In this case, the only option is to make ddterm fullscreen too

@amezin
Copy link
Member

amezin commented Dec 13, 2022

I have plans to write an xterm.js-based terminal emulator using GNOME Shell's UI (instead of the current implementation with a separate Gtk application). It should solve all window management issues, like this one.

However, it won't happen soon, as it will likely be a separate project, written (almost) from scratch.

#269

@alupula-vk
Copy link

Try using a tile instead of the full screen....check whether it works! Even I use the full screen mode rarely!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants