Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QIDO-RS does not respect limit and offset parameters #19

Open
swederik opened this issue Sep 30, 2019 · 2 comments
Open

QIDO-RS does not respect limit and offset parameters #19

swederik opened this issue Sep 30, 2019 · 2 comments

Comments

@swederik
Copy link
Member

From @pieper, it looks like the limit and offset parameters are not being applied.

@lassoan
Copy link

lassoan commented Nov 4, 2020

This causing an issue at various places:

  • Slicer's DICOMwebBrowser queries list of studies in batches, increasing the offset by the number of studies received, until no new studies are received. This loop runs infinitely, as the offset parameter is ignored.
  • OHIF viewer can only shows the first 25 studies (max 100, if you set rows per page to 100), clicking "Next" has no effect at all

This essentially renders the OHIF viewer unusable for any data collection that contain more than 100 studies.

@swederik
Copy link
Member Author

Looks like we just need to fix the slice call here:

reply.code(200).send(res.slice(0, Number(request.query.limit)));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants