From f000f0f5da3370414f76e94d27a6b652c185f2f4 Mon Sep 17 00:00:00 2001
From: Dan Connolly <dckc@madmode.com>
Date: Wed, 20 Jan 2021 17:53:14 -0600
Subject: [PATCH] build(xsnap): don't set mxDebug in release builds

fixes #2216

only tested on lin, not mac nor win
---
 packages/xsnap/makefiles/lin/xsnap.mk  | 3 +--
 packages/xsnap/makefiles/mac/xsnap.mk  | 3 +--
 packages/xsnap/makefiles/win/xsnap.mak | 2 +-
 3 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/packages/xsnap/makefiles/lin/xsnap.mk b/packages/xsnap/makefiles/lin/xsnap.mk
index ad3d20f580ea..249fa8c8a762 100644
--- a/packages/xsnap/makefiles/lin/xsnap.mk
+++ b/packages/xsnap/makefiles/lin/xsnap.mk
@@ -25,7 +25,6 @@ C_OPTIONS = \
 	-fno-common \
 	-DINCLUDE_XSPLATFORM \
 	-DXSPLATFORM=\"xsnap.h\" \
-	-DmxDebug=1 \
 	-DmxMetering=1 \
 	-DmxParse=1 \
 	-DmxRun=1 \
@@ -41,7 +40,7 @@ C_OPTIONS += \
 	-Wno-misleading-indentation \
 	-Wno-implicit-fallthrough
 ifeq ($(GOAL),debug)
-	C_OPTIONS += -g -O0 -Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter
+	C_OPTIONS += -g -O0 -Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -DmxDebug=1
 else
 	C_OPTIONS += -O3
 endif
diff --git a/packages/xsnap/makefiles/mac/xsnap.mk b/packages/xsnap/makefiles/mac/xsnap.mk
index bb77735d16f5..ce6bbfa2739c 100644
--- a/packages/xsnap/makefiles/mac/xsnap.mk
+++ b/packages/xsnap/makefiles/mac/xsnap.mk
@@ -28,7 +28,6 @@ C_OPTIONS = \
 	$(MACOS_VERSION_MIN) \
 	-DINCLUDE_XSPLATFORM \
 	-DXSPLATFORM=\"xsnap.h\" \
-	-DmxDebug=1 \
 	-DmxMetering=1 \
 	-DmxParse=1 \
 	-DmxRun=1 \
@@ -44,7 +43,7 @@ ifneq ("x$(SDKROOT)", "x")
 	C_OPTIONS += -isysroot $(SDKROOT)
 endif
 ifeq ($(GOAL),debug)
-	C_OPTIONS += -g -O0 -Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter
+	C_OPTIONS += -g -O0 -Wall -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -DmxDebug=1
 else
 	C_OPTIONS += -O3
 endif
diff --git a/packages/xsnap/makefiles/win/xsnap.mak b/packages/xsnap/makefiles/win/xsnap.mak
index f3de5faafa9c..9907f179d0e6 100644
--- a/packages/xsnap/makefiles/win/xsnap.mak
+++ b/packages/xsnap/makefiles/win/xsnap.mak
@@ -20,7 +20,6 @@ C_OPTIONS = \
 	/D _CRT_SECURE_NO_DEPRECATE \
 	/D INCLUDE_XSPLATFORM \
 	/D XSPLATFORM=\"xsnap.h\" \
-	/D mxDebug=1 \
 	/D mxMetering=1 \
 	/D mxParse=1 \
 	/D mxRun=1 \
@@ -35,6 +34,7 @@ C_OPTIONS = \
 !IF "$(GOAL)"=="debug"
 C_OPTIONS = $(C_OPTIONS) \
 	/D _DEBUG \
+	/D mxDebug=1 \
 	/Fp$(TMP_DIR_DBG)\ \
 	/Od \
 	/W3 \