-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove timestamps from storage and event logs #503
Comments
Are we effectively reverting this PR or is there stuff we need to keep? most of it seems related to timestamps |
Basically reverting it, but we aren't doing this until after GR12 when we flesh out protocol specs/contracts a bit more, because it's already done and the added gas costs on Polygon for GR12 are negligible |
@mk1r noticed you were assigned to this, but leaving this unassigned for now since there's currently no plans to work on this |
I think we need to keep these changes in place because although in most cases we can use the @mds1 - how do you feel about closing this out? |
This is the main thing I'd want to verify before closing this out. When using an event listener with ethers, it's still listening for each block under the hood. (And possibly something for query filters where it already retrieved block info). Meaning that I suspect we might have already queried for block metadata (i.e. In other words, before closing this out we should verify that there isn't a way to rewrite our event queries to get timestamp for free without an extra RPC call |
This was implemented in #497, but it turns out we don't actually need these helpers because we can get the timestamps from the subgraph + event listeners as needed cc @gdixon @thelostone-mc
The text was updated successfully, but these errors were encountered: