We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rowChart with renderTitleLabel(true) has vertically misaligned title labels:
Both labels and titles have the same y, but labels have also dy. Adding dy to titles fixes the problem.
y
dy
diff --git a/src/row-chart.js b/src/row-chart.js index d7a16de..347ae7a 100644 --- a/src/row-chart.js +++ b/src/row-chart.js @@ -241,6 +241,7 @@ dc.rowChart = function (parent, chartGroup) { var titlelab = rows.select('.' + _titleRowCssClass) .attr('x', _chart.effectiveWidth() - _titleLabelOffsetX) .attr('y', _labelOffsetY) + .attr('dy', _dyOffset) .attr('text-anchor', 'end') .on('click', onClick) .attr('class', function (d, i) {
The text was updated successfully, but these errors were encountered:
This looks like a reasonable fix. The _dyOffset fix for titles is relatively new and it just needs to be applied to labels as well.
_dyOffset
Sorry, something went wrong.
Thanks @wojdyr!
@gordonwoodhull Is this patch to be applied soon? I can submit the pull request with @wojdyr 's patch if he is not able to do it now.
Yes, please do. There is a lot to keep track of in this project, and all pull requests help, even small ones. Thanks!
Fixed in 2.0 beta 28. Thanks @adrm!
No branches or pull requests
rowChart with renderTitleLabel(true) has vertically misaligned title labels:
Both labels and titles have the same
y
, but labels have alsody
.Adding
dy
to titles fixes the problem.The text was updated successfully, but these errors were encountered: