Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dc v3 related warning message while using dc v4 #1664

Open
benjaminh opened this issue Mar 6, 2020 · 1 comment
Open

dc v3 related warning message while using dc v4 #1664

benjaminh opened this issue Mar 6, 2020 · 1 comment

Comments

@benjaminh
Copy link

benjaminh commented Mar 6, 2020

With https://unpkg.com/dc@4/dist/dc.js, I get this message in the console :
You are using d3.schemeCategory20c, which has been removed in D3v5. See the explanation at https://github.com/d3/d3/blob/master/CHANGES.md#changes-in-d3-50. DC is using it for backward compatibility, however it will be changed in DCv3.1

So my guess is that dc v4 came back to using d3.schemeCategory20c, is that correct ?

@gordonwoodhull
Copy link
Contributor

Thanks for pointing this out. It was a bad idea to specify in advance when the compatibility color scheme would be removed from DC.

It has not been removed yet.

That said you should still follow the advice from this warning and stop using this color scheme. It was removed from D3 because it was ambiguous.

I’ll fix this issue by removing the mention of 3.1 from the warning message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants