Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old color schemes lingering #1564

Open
gordonwoodhull opened this issue Aug 27, 2019 · 0 comments
Open

old color schemes lingering #1564

gordonwoodhull opened this issue Aug 27, 2019 · 0 comments

Comments

@gordonwoodhull
Copy link
Contributor

This is a follow-up to #1403.

We were focused on removing schemeCategory20c, because it's bad, but we ended up introducing a color defaulting system which is more general.

This Stack Overflow question points out that the coordinate grid mixin will still default to schemeCategory10, which is less bad but not what the user may expect if they set dc.config.defaultColors():

_chart.colors(d3.scaleOrdinal(d3.schemeCategory10));

Seems like we should remove that - I guess the purpose of this line was to opt out of 20-category and use 10-category, because the 20-category color scheme is bad. So it's redundant now.

Also, searching the sources for "scheme", I noticed that the color mixin still references schemeCategory20c in the documentation, when it should refer to dc.config.defaultColors() instead:

* @param {d3.scale} [colorScale=d3.scaleOrdinal(d3.schemeCategory20c)]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant