Skip to content
This repository has been archived by the owner on Oct 27, 2024. It is now read-only.

Toolchain to Deno 2 #22

Closed
3 tasks
Malix-Labs opened this issue Oct 24, 2024 · 5 comments
Closed
3 tasks

Toolchain to Deno 2 #22

Malix-Labs opened this issue Oct 24, 2024 · 5 comments

Comments

@Malix-Labs
Copy link

@dbushell
Copy link
Owner

Thanks I've left a comment on the PR #20 (comment)

I think there is some confusion here regarding Node / Deno.

SvelteKit and its adapters are basically Node projects. Only the built output from this adapter is built for Deno. Changing package.json to deno.json wouldn't make sense.

At some point SvelteKit and Deno will be fully compatibility with each other, at that time this adapter becomes obsolete.

@Malix-Labs
Copy link
Author

Malix-Labs commented Oct 25, 2024

@dbushell indeed but the toolchain of this repository can be converted to deno, right ?

It has more interest in dev than in prod but it kinda makes sense for a deno project

@dbushell
Copy link
Owner

The toolchain is Node. Only the adapter build output targets Deno to serve the website.

If you mean using Deno for the entire toolchain, for Vite development etc, I don't know if Deno if fully compatible with SvelteKit yet. If it is there is no need for this adapter, using the Node adapter would be perfectly fine.

@Malix-Labs
Copy link
Author

Malix-Labs commented Oct 25, 2024

If you mean using Deno for the entire toolchain

Yep

I don't know if Deno if fully compatible with SvelteKit yet

Yes, but not out of the box (see sveltejs/cli#214)
The node adapter is fully compatible

However I don't think it makes this project obsolete because of #5 (comment)

I know a thin mapping API layer is not much but it's still something

@Malix-Labs Malix-Labs changed the title Deno 2 Toolchain to Deno 2 Oct 25, 2024
@dbushell
Copy link
Owner

I'd recommend starting a fork if you're looking for a full Deno toolchain. Personally I think it'd be a wasted effort I don't see there being anything to gain. You can't escape Node APIs in the SvelteKit dev/build process.

I'll probably archive this repo very soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants