Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fmt_tty.setup_std_outputs doesn't set the margins #11

Open
Drup opened this issue Sep 9, 2015 · 6 comments
Open

Fmt_tty.setup_std_outputs doesn't set the margins #11

Drup opened this issue Sep 9, 2015 · 6 comments

Comments

@Drup
Copy link
Contributor

Drup commented Sep 9, 2015

Not sure if that's intended.

@dbuenzli
Copy link
Owner

dbuenzli commented Sep 9, 2015

Unclear.

@Drup
Copy link
Contributor Author

Drup commented Sep 9, 2015

@dbuenzli
Copy link
Owner

dbuenzli commented Sep 9, 2015

I meant Not sure if that's intended : unclear. For these reasons:

  1. If we assume pure text dump (âlâ cmdliner), then I would certainly like to set the margin if < 80 columns but not if greater because of basic typographic rules for readability.
  2. If we assume widgetgiligili, then a) width should be arbitrary b) it should be able to react to changes, which brings us to register formatters for change and I'm not sure this is the right place to do it.

@dbuenzli
Copy link
Owner

dbuenzli commented Sep 9, 2015

If we assume pure text dump

in a tty.

@Drup
Copy link
Contributor Author

Drup commented Sep 9, 2015

What about providing the appropriate functions but not calling them automatically, then ?

@dbuenzli
Copy link
Owner

dbuenzli commented Sep 9, 2015

What about providing the appropriate functions but not calling them automatically, then ?

Yeah, but then I feel I have the moral obligation (le problème avec la morale c'est que c'est toujours la morale des autres) to also provide the reactive API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants