Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore nolock behaviour from 1.4.3 #553

Closed
cody-scott opened this issue Sep 14, 2024 · 1 comment
Closed

Restore nolock behaviour from 1.4.3 #553

cody-scott opened this issue Sep 14, 2024 · 1 comment

Comments

@cody-scott
Copy link
Collaborator

See this thread. #204

Need to restore this behaviour via sqlserver__information_schema_hints.

Fabric has a regression in get_catalog_relations and get_catalog where they are incorrectly applying {{ information_schema_hints() }}. https://github.com/microsoft/dbt-fabric/blob/main/dbt/include/fabric/macros/adapters/catalog.sql#L99 and https://github.com/microsoft/dbt-fabric/blob/main/dbt/include/fabric/macros/adapters/catalog.sql#L226 both place the {{ information_schema_hints() }} after the ON, not after the table.

Copying their implementation to remove those lines while waiting for upstream fix. microsoft/dbt-fabric#228
@cody-scott
Copy link
Collaborator Author

resolved in commit 9140793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cody-scott