You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched the existing issues, and I could not find an existing issue for this bug
Current Behavior
Users of the Ruff VSCode extension are now seeing huge numbers of "false positive" lint warnings for docstring errors. All of these have been tagged with # noqa: D.
The issue seems to be a change in how Ruff interprets those codes, which rolled out sometime between 0.264 and 0.285. This popped up because the most recent versions of the VSCode extension are on 0.285, but these errors do not fire in our pre-commit runs either in CI or via make lint since that Ruff version is pinned to 0.260.
For now, VSCode users can get compatible behavior by installing an earlier version of Ruff (v2023.14.0 appears to be just fine), but we should get this updated.
Note fixing this requires a lot of changes to docstring lint check overrides:
40 D101
685 D102
222 D103
39 D105
3 D106
69 D107
Anyone who takes this on should probably suppress those errors at first and then re-enable one by one after a big fix. D102, in particular, probably warrants a global find/replace.
Also worth noting, it's likely a lot of these can be resolved by removing the noqa and adding an @OverRide decorator to the offending method.
Expected Behavior
Ideally, Ruff in the command line and CI and Ruff in VSCode would have matching results.
Steps To Reproduce
Update Ruff, run the CLI, observe the errors. VSCode users with the most recent Ruff extension can see them, just tons of yellow squiggles everywhere....
Relevant log output
No response
Environment
- OS:
- Python:
- dbt:
- metricflow:
Which database are you using?
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered:
Is this a new bug in metricflow?
Current Behavior
Users of the Ruff VSCode extension are now seeing huge numbers of "false positive" lint warnings for docstring errors. All of these have been tagged with
# noqa: D
.The issue seems to be a change in how Ruff interprets those codes, which rolled out sometime between 0.264 and 0.285. This popped up because the most recent versions of the VSCode extension are on 0.285, but these errors do not fire in our pre-commit runs either in CI or via
make lint
since that Ruff version is pinned to 0.260.For now, VSCode users can get compatible behavior by installing an earlier version of Ruff (v2023.14.0 appears to be just fine), but we should get this updated.
Note fixing this requires a lot of changes to docstring lint check overrides:
Anyone who takes this on should probably suppress those errors at first and then re-enable one by one after a big fix. D102, in particular, probably warrants a global find/replace.
Also worth noting, it's likely a lot of these can be resolved by removing the noqa and adding an @OverRide decorator to the offending method.
Expected Behavior
Ideally, Ruff in the command line and CI and Ruff in VSCode would have matching results.
Steps To Reproduce
Update Ruff, run the CLI, observe the errors. VSCode users with the most recent Ruff extension can see them, just tons of yellow squiggles everywhere....
Relevant log output
No response
Environment
Which database are you using?
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: