Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one auto-merge per hour can cause latency for new package versions #1765

Closed
dbeatty10 opened this issue Aug 11, 2022 · 1 comment
Closed

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Aug 11, 2022

Potentially related to #1484

Current functionality

A script runs at the top of every hour and looks for newly released package versions. When a new tag is added to a GitHub repo that is listed on the dbt Package Hub, a pull request is automatically opened within this (hub.getdbt.com) repo. These pull requests are somehow merged automatically.

The problem is that only one pull request is merged per hour. If multiple pull requests are opened within a single hour, then duplicate pull requests will be opened every subsequent hour until all PRs are able to merge.

Desired functionality

Do at least one of the following:

  1. Merge multiple PRs per hour, or
  2. Open a single PR containing all new package versions (rather than separate PRs)

Either one of these options should solve the problems listed above.

Also, it would be nice if 100% duplicate PRs weren't opened. Although related, it could be a separate issue opened within https://github.com/dbt-labs/hubcap. It could be accomplished by naming the PR or the branch using a md5 hash of the git diff or something similar.

Implementation

The 2nd option would actually be implemented within https://github.com/dbt-labs/hubcap rather than this repo. 👈 I lean towards trying this one first.

The 1st option could theoretically be accomplished within this repo, but I don't know what is dictating only one PR merge per hour -- it might be something with these GitHub Actions, but it might be something else.

@dbeatty10 dbeatty10 changed the title Only one auto-merge per hour can causes latency for new versions Only one auto-merge per hour can cause latency for new package versions Oct 27, 2022
@dbeatty10
Copy link
Contributor Author

Resolved by dbt-labs/hubcap#154

Confirmed to work by #2074 (two different packages updated by the same pull request).

#2071 shows an example of two different versions of the same package within one pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant