add required and type to sm and metrics #6534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
nataliefiann
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Hiya @mirnawong1
The tables are amazing! Thanks for creating this. I've approved this for you. I made some non-blocking suggestions (adding full stops) but for some reason I couldn't commit the changes so they fed through as reviews.
Kind Regards
Natalie
Co-authored-by: nataliefiann <[email protected]>
Co-authored-by: nataliefiann <[email protected]>
Co-authored-by: nataliefiann <[email protected]>
Co-authored-by: nataliefiann <[email protected]>
Co-authored-by: nataliefiann <[email protected]>
Co-authored-by: nataliefiann <[email protected]>
Co-authored-by: nataliefiann <[email protected]>
Co-authored-by: nataliefiann <[email protected]>
Co-authored-by: nataliefiann <[email protected]>
Co-authored-by: nataliefiann <[email protected]>
Co-authored-by: nataliefiann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds a separate field for the type and required so it doesn't get lost in the description
updates were made to all metrics and semantic model pages
Resolves #6320
🚀 Deployment available! Here are the direct links to the updated files: