From 2e28ca0bfee02f5a566b0c5d49bb24a6cce265eb Mon Sep 17 00:00:00 2001 From: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Date: Sat, 7 Oct 2023 14:32:04 -0600 Subject: [PATCH 01/10] `group` config for semantic models --- .../docs/reference/resource-configs/group.md | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/website/docs/reference/resource-configs/group.md b/website/docs/reference/resource-configs/group.md index dd73d99edff..acd5a878d6b 100644 --- a/website/docs/reference/resource-configs/group.md +++ b/website/docs/reference/resource-configs/group.md @@ -16,6 +16,7 @@ This functionality is new in v1.5. { label: 'Tests', value: 'tests', }, { label: 'Analyses', value: 'analyses', }, { label: 'Metrics', value: 'metrics', }, + { label: 'Semantic models', value: 'semantic_models', }, ] }> @@ -265,6 +266,44 @@ metrics: + + + + + +Support for grouping semantic models was added in dbt Core v1.7 + + + + + + + +```yaml +semantic_models: + [](resource-path): + [+](plus-prefix)group: finance +``` + + + + + +```yaml +version: 2 + +semantic_models: + - name: [] + group: finance + +``` + + + + + + + ## Definition From e6fc24f0901329250dc21672340222b5a7863a1e Mon Sep 17 00:00:00 2001 From: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Date: Sat, 7 Oct 2023 14:53:00 -0600 Subject: [PATCH 02/10] Fix version blocks across multiple resource types --- .../docs/reference/resource-configs/group.md | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/website/docs/reference/resource-configs/group.md b/website/docs/reference/resource-configs/group.md index acd5a878d6b..f04c08556b9 100644 --- a/website/docs/reference/resource-configs/group.md +++ b/website/docs/reference/resource-configs/group.md @@ -29,8 +29,6 @@ Support for grouping models was added in dbt Core v1.5 - - ```yml @@ -66,6 +64,8 @@ select ... ``` + + @@ -80,8 +80,6 @@ Support for grouping seeds was added in dbt Core v1.5 - - ```yml @@ -102,6 +100,8 @@ seeds: + + @@ -115,8 +115,6 @@ Support for grouping snapshots was added in dbt Core v1.5 - - ```yml @@ -143,6 +141,8 @@ select ... + + @@ -156,8 +156,6 @@ Support for grouping tests was added in dbt Core v1.5 - - ```yml @@ -210,6 +208,8 @@ select ... + + @@ -239,8 +239,6 @@ Support for grouping metrics was added in dbt Core v1.5 - - ```yaml @@ -264,6 +262,8 @@ metrics: + + From 871a01f5923c087e7274cd5d6f4ede329e26f607 Mon Sep 17 00:00:00 2001 From: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Date: Sat, 7 Oct 2023 15:01:39 -0600 Subject: [PATCH 03/10] Fix placement of closing tag for VersionBlock --- website/docs/reference/resource-configs/group.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/website/docs/reference/resource-configs/group.md b/website/docs/reference/resource-configs/group.md index f04c08556b9..7e4df42597f 100644 --- a/website/docs/reference/resource-configs/group.md +++ b/website/docs/reference/resource-configs/group.md @@ -64,10 +64,10 @@ select ... ``` - - + + From d57c911ddda85ce72c42d48447fe749d6077653d Mon Sep 17 00:00:00 2001 From: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Date: Sat, 7 Oct 2023 15:39:10 -0600 Subject: [PATCH 04/10] Clarify the definition --- website/docs/reference/resource-configs/group.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/docs/reference/resource-configs/group.md b/website/docs/reference/resource-configs/group.md index 7e4df42597f..0700f2d9bb3 100644 --- a/website/docs/reference/resource-configs/group.md +++ b/website/docs/reference/resource-configs/group.md @@ -307,7 +307,7 @@ semantic_models: ## Definition -An optional configuration for grouping models, analysis, snapshots, tests, and metrics. When a resource is grouped, dbt will allow it to reference private models within the same group. +An optional configuration for assigning a group to a resource. When a resource is grouped, dbt will allow it to reference private models within the same group. For more details on reference access between resources in groups, check out [model access](/docs/collaborate/govern/model-access#groups). From 8ef88b900b97e6b73d227ce29d9ae9fc6c76cb0d Mon Sep 17 00:00:00 2001 From: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Date: Tue, 7 Nov 2023 20:21:24 -0700 Subject: [PATCH 05/10] Match the style of other resource types --- .../docs/reference/resource-configs/group.md | 41 +------------------ 1 file changed, 2 insertions(+), 39 deletions(-) diff --git a/website/docs/reference/resource-configs/group.md b/website/docs/reference/resource-configs/group.md index acaedbe5424..07d06c88955 100644 --- a/website/docs/reference/resource-configs/group.md +++ b/website/docs/reference/resource-configs/group.md @@ -267,11 +267,11 @@ metrics: - + -Support for grouping semantic models was added in dbt Core v1.7 +Support for grouping semantic models has been added in dbt Core v1.7. @@ -304,43 +304,6 @@ semantic_models: - - - - -Support for grouping semantic models has been added in dbt Core v1.7. - - - - - - - -```yml -semantic_models: - - name: model_name - group: finance - -``` - - - - - -```yml -semantic_models: - [](resource-path): - +group: finance -``` - - - -The `group` configuration can be nested under the `config` key. - - - - - ## Definition From e9f77c2c580c85cd597aa9de9276fe583134419e Mon Sep 17 00:00:00 2001 From: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Date: Tue, 7 Nov 2023 20:26:23 -0700 Subject: [PATCH 06/10] Fix resource key in `dbt_project.yml` --- website/docs/reference/resource-configs/group.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/docs/reference/resource-configs/group.md b/website/docs/reference/resource-configs/group.md index 07d06c88955..a663585cdd6 100644 --- a/website/docs/reference/resource-configs/group.md +++ b/website/docs/reference/resource-configs/group.md @@ -280,7 +280,7 @@ Support for grouping semantic models has been added in dbt Core v1.7. ```yaml -semantic_models: +semantic-models: [](resource-path): [+](plus-prefix)group: finance ``` From 5cc4101ff7a65f94e9c5f145a3fadf14e4eb2564 Mon Sep 17 00:00:00 2001 From: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Date: Tue, 7 Nov 2023 20:29:50 -0700 Subject: [PATCH 07/10] Restore order of `dbt_project.yml` vs. `models/semantic_models.yml` Even though the rest of the resource types have them in the other order --- .../docs/reference/resource-configs/group.md | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/website/docs/reference/resource-configs/group.md b/website/docs/reference/resource-configs/group.md index a663585cdd6..89d03c95bc9 100644 --- a/website/docs/reference/resource-configs/group.md +++ b/website/docs/reference/resource-configs/group.md @@ -277,16 +277,6 @@ Support for grouping semantic models has been added in dbt Core v1.7. - - -```yaml -semantic-models: - [](resource-path): - [+](plus-prefix)group: finance -``` - - - ```yaml @@ -300,6 +290,16 @@ semantic_models: + + +```yaml +semantic-models: + [](resource-path): + [+](plus-prefix)group: finance +``` + + + From 839aab91b2ee79194b1aa14c788562e7fad8ac40 Mon Sep 17 00:00:00 2001 From: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Date: Tue, 7 Nov 2023 20:30:59 -0700 Subject: [PATCH 08/10] Remove "version: 2" --- website/docs/reference/resource-configs/group.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/website/docs/reference/resource-configs/group.md b/website/docs/reference/resource-configs/group.md index 89d03c95bc9..53f5acb79ff 100644 --- a/website/docs/reference/resource-configs/group.md +++ b/website/docs/reference/resource-configs/group.md @@ -280,8 +280,6 @@ Support for grouping semantic models has been added in dbt Core v1.7. ```yaml -version: 2 - semantic_models: - name: [] group: finance From fff3afc84ae2e4b1ffaca7e880ef1115843b8b77 Mon Sep 17 00:00:00 2001 From: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Date: Tue, 7 Nov 2023 21:02:11 -0700 Subject: [PATCH 09/10] Add generic placeholders for the group name Rather than realistic examples --- website/docs/reference/resource-configs/group.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/website/docs/reference/resource-configs/group.md b/website/docs/reference/resource-configs/group.md index 53f5acb79ff..36b0be341d2 100644 --- a/website/docs/reference/resource-configs/group.md +++ b/website/docs/reference/resource-configs/group.md @@ -282,7 +282,7 @@ Support for grouping semantic models has been added in dbt Core v1.7. ```yaml semantic_models: - name: [] - group: finance + group: ``` @@ -293,7 +293,7 @@ semantic_models: ```yaml semantic-models: [](resource-path): - [+](plus-prefix)group: finance + [+](plus-prefix)group: ``` From 1f20f4e1c3452180abca1998b03daead2f2a2165 Mon Sep 17 00:00:00 2001 From: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Date: Tue, 7 Nov 2023 21:03:17 -0700 Subject: [PATCH 10/10] Remove extraneous (and misleading) brackets --- website/docs/reference/resource-configs/group.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/docs/reference/resource-configs/group.md b/website/docs/reference/resource-configs/group.md index 36b0be341d2..bce2a72136e 100644 --- a/website/docs/reference/resource-configs/group.md +++ b/website/docs/reference/resource-configs/group.md @@ -281,7 +281,7 @@ Support for grouping semantic models has been added in dbt Core v1.7. ```yaml semantic_models: - - name: [] + - name: group: ```