Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model contracts: matrix showing which constraints are supported/enforced by data warehouse #3282

Closed
1 task
Tracked by #3362
runleonarun opened this issue Apr 27, 2023 · 0 comments · Fixed by #3944
Closed
1 task
Tracked by #3362

Model contracts: matrix showing which constraints are supported/enforced by data warehouse #3282

runleonarun opened this issue Apr 27, 2023 · 0 comments · Fixed by #3944
Assignees
@matthewshaver
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) improvement Use this when an area of the docs needs improvement as it's currently unclear
Milestone
dbt Core v1.5 Doc...

Comments

@runleonarun
Copy link
Collaborator

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

Add the table or matrix to this page https://docs.getdbt.com/docs/collaborate/govern/model-contracts

What part(s) of the page would you like to see updated?

Add a matrix or tabbed view that identifies which platforms support constraints and whether they are supported and/or enforced.

References

  • Jeremy made a table of these a few months ago, to guide the implementation for the DWH adapters that we maintain: [CT-2199] Generalize constraint compatibility warnings dbt-core#7067 (comment).

  • Doug also has these suggestions for how this could be laid out. Here's an example:

    constraint type dbt-redshift
    not_null 🌕 supported & enforced
    primary_key 🌗 supported; not enforced
    foreign_key 🌗 supported; not enforced
    unique 🌗 supported; not enforced
    check 🌑 not supported

Additional information

No response
@runleonarun runleonarun added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) labels Apr 27, 2023
@runleonarun runleonarun mentioned this issue Apr 27, 2023
Merged
2 tasks
@jtcohen6 jtcohen6 added this to the dbt Core v1.5 Documentation milestone Jun 20, 2023
@jtcohen6 jtcohen6 changed the title Add matrix that shows supported and/or enforced by date warehouse Model contrcts: matrix showing which constraints are supported/enforced by data warehouse Jun 20, 2023
@jtcohen6 jtcohen6 changed the title Model contrcts: matrix showing which constraints are supported/enforced by data warehouse Model contracts: matrix showing which constraints are supported/enforced by data warehouse Jun 20, 2023
@jtcohen6 jtcohen6 mentioned this issue Jun 20, 2023
Closed
@matthewshaver matthewshaver linked a pull request Aug 17, 2023 that will close this issue
Adapter constraint support tables #3944
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewshaver matthewshaver

Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.5 Docs impact for the v1.5 release (Apr 2023) improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
dbt Core v1.5 Documentation
Development

Successfully merging a pull request may close this issue.

Adapter constraint support tables dbt-labs/docs.getdbt.com
3 participants
@runleonarun @jtcohen6 @matthewshaver