Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain "Allow edits from maintainers" within the contributing guide #913

Closed
dbeatty10 opened this issue Jun 4, 2024 · 0 comments · Fixed by #917
Closed

Explain "Allow edits from maintainers" within the contributing guide #913

dbeatty10 opened this issue Jun 4, 2024 · 0 comments · Fixed by #917

Comments

@dbeatty10
Copy link
Contributor

Describe the documentation update

It is easier to collaborate on Pull Requests on user-owned forks when "Allow edits from maintainers" is selected by the contributor.

So we should add a note to our contributing guide that says something to that effect.

Additional context

We've had cases where this is not enabled. This means that a maintainer can't push changes and all changes need to be initiated by the contributor. To make changes and merge a PR expediently, a new PR may need to be opened by the maintainer (preserving commits if possible, of course). In that scenario, the main downside is the PR that is merged doesn't have the handle of the contributor, so may not be fully credited in the changelog. The original PR would need to be closed as well.

Who will this benefit?

This makes collaboration easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant