Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the implementation of deduplicate that uses a natural join #824

Closed
1 of 5 tasks
dbeatty10 opened this issue Aug 11, 2023 · 3 comments
Closed
1 of 5 tasks
Labels
bug Something isn't working Stale

Comments

@dbeatty10
Copy link
Contributor

Describe the bug

The current default implementation of deduplicate uses a natural join that is not null safe.

After the next release, this issue won't affect bigquery, databricks, postgres, redshift, or snowflake, because they will each have their own null safe implementation that will override the default.

#815 contains alternative approaches that will allow the user to choose a null safe option that is most appropriate for them. In addition to that, we want to get the not safe implementation on a deprecation path.

Then in a future version, we should raise an error to replace the deprecation warning.

System information

The contents of your packages.yml file:

Which database are you using dbt with?

  • postgres
  • redshift
  • bigquery
  • snowflake
  • other (specify: only affects adapters other than the above)

Are you interested in contributing the fix?

Yep 👍

@dbeatty10 dbeatty10 added bug Something isn't working triage and removed triage labels Aug 11, 2023
Copy link

github-actions bot commented Feb 8, 2024

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 8, 2024
@dbeatty10 dbeatty10 removed the Stale label Feb 8, 2024
Copy link

github-actions bot commented Aug 7, 2024

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 7, 2024
Copy link

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

No branches or pull requests

1 participant