Add condition parameter to get_column_values

[djbelknapaw]

Describe the feature

It would be handy if get_column_values had a condition that would stick a where <condition> in the query. I've got a big table and only want values from a subset of records.

Describe alternatives you've considered

• Writing a macro of my own that grabs specifically what I want.
• Pointing the get_column_values macro at a model that filters records for me, which leads to models that exist just for the filter.

Who will this benefit?

I have a big tall table with a whole bunch of key-value pairs that belong to different record types. I want to use pivot with a list of columns, but I want that list of columns to be specific to just one record type at a time.

Or more generally, maybe you want column values that only come from non-soft-deleted records (or myriad reasons why you might just want a subset).

Are you interested in contributing this feature?

I can probably contribute to this if you're open to this change.

[joellabes]

@djbelknapaw thanks for opening this! That use case makes sense, thanks for describing it (my gut reaction was "if you already know what you're filtering to, why do you need this at all" 😅)

I'd be happy to see a PR which adds this functionality and tests 👍 let me know if you need any help along the way!

[epapineau]

Looks like I just opened a redundant issue #582 (sorry). I'd be happy to tackle this.