Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "generic test" naming style instead of "schema test" #485

Closed
joellabes opened this issue Jan 31, 2022 · 2 comments · Fixed by #521
Closed

Use "generic test" naming style instead of "schema test" #485

joellabes opened this issue Jan 31, 2022 · 2 comments · Fixed by #521
Labels
bug Something isn't working good first issue

Comments

@joellabes
Copy link
Contributor

joellabes commented Jan 31, 2022

Schema tests were renamed to generic tests - the readme and folder structures should update to reflect that.

  • readme headers and anchor links
  • body of readme (the "this schema test..." text under each test. Even better: drop that part and say something like "Assert the that two relations have the same number of rows"
  • folder path for the schema tests

Are you interested in contributing the fix?

Yes

@joellabes joellabes added bug Something isn't working triage good first issue and removed triage labels Jan 31, 2022
@b-moynihan
Copy link
Contributor

Hi @joellabes, I'm interesting in taking a look at working on this issue. I see it was opened in late Jan, just confirming this is still relevant and there's no existing PR addressing this? :)

@dbeatty10
Copy link
Contributor

Fixed by #521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants