Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-947] Test_incremental_strategy failed on main #410

Closed
ChenyuLInx opened this issue Jul 27, 2022 · 2 comments
Closed

[CT-947] Test_incremental_strategy failed on main #410

ChenyuLInx opened this issue Jul 27, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@ChenyuLInx
Copy link
Contributor

ChenyuLInx commented Jul 27, 2022

Describe the bug

tests/integration/incremental_strategies/test_incremental_strategies.py::TestInsertOverwrite along with some other tests are failing in current main branch. Noticed the failure while working on getting the tests working in #377. All other tests are passing now there but the TestInsertOverwrite is still failing.

Log for failure in main

Steps To Reproduce

I wasn't able to run the test locally but linked the fail log above

Expected behavior

Tests passing

@ChenyuLInx ChenyuLInx added bug Something isn't working triage labels Jul 27, 2022
@github-actions github-actions bot changed the title Test_incremental_strategy failed on main [CT-947] Test_incremental_strategy failed on main Jul 27, 2022
@jtcohen6
Copy link
Contributor

We switched over to using a high-concurrency Databricks cluster for CI, which is the only way to support both access control and Python + SQL.

https://docs.databricks.com/security/access-control/table-acls/table-acl.html#create-a-cluster-enabled-for-table-access-control

While setting up that new cluster, I forgot the very important detail that I had previously documented (https://docs.getdbt.com/reference/resource-configs/spark-configs#incremental-models):

If connecting via a Databricks cluster + ODBC driver (method: odbc + cluster), you must include set spark.sql.sources.partitionOverwriteMode DYNAMIC in the cluster Spark Config in order for dynamic partition replacement to work (incremental_strategy: insert_overwrite + partition_by).

Success on rerun for branch in #377: https://app.circleci.com/pipelines/github/dbt-labs/dbt-spark/1198/workflows/bf4ec4c2-dd2e-4228-b86e-1af5ee51d9c6/jobs/4642

@jtcohen6 jtcohen6 removed the triage label Jul 28, 2022
@ChenyuLInx
Copy link
Contributor Author

Test has moved back and now all tests on main passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants