Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-617] [Spark]: Upgrade the version of spark to 3.x #348

Closed
nssalian opened this issue May 6, 2022 · 4 comments
Closed

[CT-617] [Spark]: Upgrade the version of spark to 3.x #348

nssalian opened this issue May 6, 2022 · 4 comments
Assignees

Comments

@nssalian
Copy link
Contributor

nssalian commented May 6, 2022

Describe the feature

The spark test image is built with a Spark 2 tag, while the open-source Spark is further into Spark 3.x.
This issue focuses on the upgrade to Spark 3 - it would unlock a host of new features that come from the migration from 2 to 3.
Proposing to use Spark 3.1.1

Concern/ future items

We should evaluate if the godatadriven/spark image is the best way forward for the community. It's versions don't seem to be kept up-to-date with the open source version. This doesn't have to occur in this issue but we should look at it in the future.

Are you interested in contributing this feature?

I'd be interested to open a PR to focus on the upgrade.

@nssalian nssalian added enhancement New feature or request triage labels May 6, 2022
@nssalian nssalian self-assigned this May 6, 2022
@github-actions github-actions bot changed the title [Spark]: Upgrade the version of spark to 3.x [CT-617] [Spark]: Upgrade the version of spark to 3.x May 6, 2022
@jtcohen6 jtcohen6 added tech_debt and removed triage labels May 6, 2022
@TalkWIthKeyboard
Copy link

@nssalian Hi, I am upgrading the Spark version too, we meet the same problem that tests get stuck for a long time, I suspect it may be caused by the resource size of the test container, if there are any other clues, I would be interesting to discuss the details of the problem with you and work it out.

@nssalian
Copy link
Contributor Author

nssalian commented May 8, 2022

Thanks, @TalkWIthKeyboard. I bumped up the size and it didn't help. I'm thinking it might be related to Spark and Thrift itself. I'll try more debugging tomorrow. Once we merge #349, I can help you get #342 functionality in.

@TalkWIthKeyboard
Copy link

@nssalian Thanks, looking forward to your work.

@jtcohen6 jtcohen6 removed the enhancement New feature or request label May 10, 2022
@leahwicz
Copy link
Contributor

@nssalian #349 completed this work, correct? I'm closing this out but if there is still more to do, just let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants