Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-795] Request #5327 for dbt-snowflake to align with dbt-core #184

Closed
DetailsDevil opened this issue Jun 30, 2022 · 3 comments
Closed
Labels
awaiting_response enhancement New feature or request

Comments

@DetailsDevil
Copy link

Describe the feature

Red/green colouring is no longer visible in dbt-snowflake v1.1 on Windows, identical issue as #5327 for dbt-core .
Instead we see unexpected characters such as [←[32mPASS←[0m in 0.82s]

Describe alternatives you've considered

I refer to #5327

Additional context

It would ideal that other adapters are updated similarly as dbt-core.

Who will this benefit?

Users of dbt adapters - in addition to users of dbt-core

Are you interested in contributing this feature?

Not at this time, I believe the work as been done.

@DetailsDevil DetailsDevil added enhancement New feature or request triage labels Jun 30, 2022
@github-actions github-actions bot changed the title Request #5327 for dbt-snowflake to align with dbt-core [CT-795] Request #5327 for dbt-snowflake to align with dbt-core Jun 30, 2022
@jtcohen6
Copy link
Contributor

Hey @DetailsDevil, I don't believe there's any change needed in this codebase to get the fix — just a matter of upgrading to the latest dbt-core.

Have you tried using dbt-snowflake==1.1.0 together with dbt-core==1.1.1? If you install dbt via pip, that should be easy. If you install via Homebrew, we just updated the formula yesterday (dbt-labs/homebrew-dbt#140).

@rloredo
Copy link

rloredo commented Sep 5, 2022

I have the same problem with logs that I get in Airflow, see here #250
I'm using the latest dbt-snowflake docker image, that doesn't have the 1.2.1 core update...

@jtcohen6
Copy link
Contributor

jtcohen6 commented Sep 6, 2022

@rloredo It sounds like the resolution to #250 was to use the global config that disables color output, which is supported.

I'm going to close this issue in the meantime.

@jtcohen6 jtcohen6 closed this as completed Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting_response enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants