-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-960] Configurable Color-Coding of Schemas/Nodes in Docs #44
Comments
Thanks @talagluck! Check out this related issue in dbt-core: dbt-labs/dbt-core#1671 This is one of those issues that spans the core + docs repos, so some coordination is required! Maybe a good approach is to hammer our that Super into this, happy to help however I can :) |
@drewbanin Another thought we were bouncing around was extending the built-in
This way we could be in better control of the color scheme by providing a handful of nicely coordinated color tags for users to use at will. |
Some really interesting conversation in that issue! Good things to think about. One thing that occurs to me is that we could probably make good use of tags for this.
Pros:
Cons:
Any thoughts? Does this work against the intended use of tags? |
Looks like Taylor and I were working at the same time :) What he said! |
Hey guys! Check out this PR - this is still pretty rough, but should give you an idea of the (minimal) code changes required in dbt-core: dbt-labs/dbt-core#1692 I like the general idea behind using tags, but I'd opt for maybe |
This is starting to click for me! I'm now sold on not overloading the I think as an MVP we could have a set of pre-set colors then in the future make it extensible to custom styles? (This isn't a strong opinion, just looking for the shortest reasonable path there). |
I'm getting started on this over here: #45 this uses artifacts generated by running dbt with this branch: dbt-labs/dbt-core#1692 the
So, lots more work to do here for sure, but wanted to do the worst possible version of this to help inform our opinions / future work! I'm going to put this down until after the dbt v0.14.1 release is complete, but looking forward to digging back in! |
I love this as a solution to both this and dbt-labs/dbt-core#1671 Thank you @drewbanin ! #grateful |
FYI @drewbanin @talagluck and I are slowly pushing this forward. We are currently working on making the custom colors not interfere w/ the user selection colors. |
Is there any updated on whether the custom colours is going to be worked on for a future release? Would be super useful for explaining to stakeholders which models are "safe" to use and which models are intermediate calculations. |
Love the idea of using node colors for "approved" consumption layers of the DAG |
We did it! Coming out in v1.3 🎉 |
This is great news @sungchun12. Will be upgrading to latest dbt asap! |
@talagluck Our color-coded dreams have come true! 🥲 |
Similar to here.
Essentially, we are interested in being able to color code either schemas or individual models in the dbt docs in a similar fashion to the way you can configure materialization of individual models.
e.g.
We really like the difference in coloration between source and models, and it would be awesome to carry this further to make it easier to distinguish between different parts of the dag.
A colleague (Taylor M.) and I are interested in working on this. We can imagine implementing this in a couple of different ways, either through the dbt_project.yml, or through configurable tags in models or schemas.
Do you have any suggestions, tips, warnings, or words of caution?
Thanks!
The text was updated successfully, but these errors were encountered: