Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Config Properties and Schema for Snapshot Hard Deletes #10972

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

peterallenwebb
Copy link
Contributor

Resolves #10235

Problem

dbt-core needs new config schema for the hard_deletes mode.

Solution

Add hard_deletes property to snapshot schema objects.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@peterallenwebb peterallenwebb requested a review from a team as a code owner November 4, 2024 17:03
@cla-bot cla-bot bot added the cla:yes label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.13%. Comparing base (a42303c) to head (29ca70f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10972      +/-   ##
==========================================
- Coverage   89.15%   89.13%   -0.02%     
==========================================
  Files         183      183              
  Lines       23764    23765       +1     
==========================================
- Hits        21186    21184       -2     
- Misses       2578     2581       +3     
Flag Coverage Δ
integration 86.51% <100.00%> (-0.02%) ⬇️
unit 62.17% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.17% <100.00%> (+<0.01%) ⬆️
Integration Tests 86.51% <100.00%> (-0.02%) ⬇️
---- 🚨 Try these New Features:

@peterallenwebb peterallenwebb requested a review from a team as a code owner November 21, 2024 21:57
@peterallenwebb peterallenwebb requested review from eddowh and removed request for a team November 21, 2024 21:57
@peterallenwebb peterallenwebb added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Nov 21, 2024
@peterallenwebb peterallenwebb changed the title Add changelog entry. Add New Config Properties and Schema for Snapshot Hard Deletes Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new record in snapshot to track deleted state (is_deleted column, zombie records)
2 participants