-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New Config Properties and Schema for Snapshot Hard Deletes #10972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10972 +/- ##
==========================================
- Coverage 89.15% 89.13% -0.02%
==========================================
Files 183 183
Lines 23764 23765 +1
==========================================
- Hits 21186 21184 -2
- Misses 2578 2581 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4 tasks
peterallenwebb
added
the
artifact_minor_upgrade
To bypass the CI check by confirming that the change is not breaking
label
Nov 21, 2024
peterallenwebb
changed the title
Add changelog entry.
Add New Config Properties and Schema for Snapshot Hard Deletes
Nov 21, 2024
gshank
approved these changes
Nov 21, 2024
peterallenwebb
added a commit
that referenced
this pull request
Nov 22, 2024
* Add changelog entry. * Update schemas and test fixtures for new snapshot meta-column * Add back comment.
gshank
added a commit
that referenced
this pull request
Nov 25, 2024
… (#11037) * Add changelog entry. * Update schemas and test fixtures for new snapshot meta-column * Add back comment. Co-authored-by: Gerda Shank <[email protected]>
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10235
Problem
dbt-core needs new config schema for the hard_deletes mode.
Solution
Add hard_deletes property to snapshot schema objects.
Checklist