Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nest Macro node meta under config #9447

Open
1 task done
QMalcolm opened this issue Jan 24, 2024 · 2 comments
Open
1 task done

Nest Macro node meta under config #9447

QMalcolm opened this issue Jan 24, 2024 · 2 comments
Labels
Impact: CA user docs [docs.getdbt.com] Needs better documentation

Comments

@QMalcolm
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-core

Short description

The old/deprecated way of having meta was putting it directly on a node. However, awhile back we deprecated that paradigm and moved to nesting meta under a node's config. For reasoning I am not aware of, this never made it to Macro nodes. We should begin supporting the "best practice" path

Acceptance criteria

  • Macro nodes have a meta property under their config property
  • During parsing, flat meta specifications should end up under the config.meta

Suggested Tests

  • Macro meta can be specified in the dbt_project.yaml config specification
  • In a macro definition, people can specify meta directly on an macro or under a macro's config, both should end up in the macro's config.meta

Impact to Other Teams

Change impacts Artifacts team (change to the artifacts)

Will backports be required?

No

Context

No response

@QMalcolm QMalcolm added user docs [docs.getdbt.com] Needs better documentation Impact: CA labels Jan 24, 2024
@QMalcolm
Copy link
Contributor Author

@jtcohen6, exact same question as on #9446. I noticed on #7440 you mentioned in a comment that we intentionally didn't move meta under config for a subset of node types. Would you be able to speak to why that was? I know we did this intentionally, but without the context it at first looks like an inconsistency.

@dbeatty10
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact: CA user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

No branches or pull requests

2 participants