Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-3256] [implementation] conditionally include saved_queries in dbt build with no-op execution #8893

Closed
1 task done
graciegoheen opened this issue Oct 25, 2023 · 0 comments · Fixed by #8937
Closed
1 task done

[CT-3256] [implementation] conditionally include saved_queries in dbt build with no-op execution #8893

graciegoheen opened this issue Oct 25, 2023 · 0 comments · Fixed by #8937
Assignees
@ChenyuLInx
Labels
backport 1.7.latest enhancement New feature or request Impact: SL user docs [docs.getdbt.com] Needs better documentation

Comments

@graciegoheen
Copy link
Contributor

graciegoheen commented Oct 25, 2023 •
edited by jtcohen6
Loading

Housekeeping

  • I am a maintainer of dbt-core

Short description

  • saved_queries can be selected by dbt build, provided a config
  • excluded by default (= config is set to False by default)
  • no-op execution by default

Acceptance criteria

If saved_query.xyz is defined, config is passed, and dbt build --select ... includes saved_query.xyz, it should be selected. We can have some placeholder behavior at execution for now, such as printing the saved query config to stdout.

Impact to Other Teams

SL

Will backports be required?

1.7 latest

Context

No response
@graciegoheen graciegoheen added user docs [docs.getdbt.com] Needs better documentation Impact: SL backport 1.7.latest labels Oct 25, 2023
@github-actions github-actions bot changed the title [implementation] conditionally include saved_queries in dbt build with no-op execution [CT-3256] [implementation] conditionally include saved_queries in dbt build with no-op execution Oct 25, 2023
@graciegoheen graciegoheen added the enhancement New feature or request label Oct 25, 2023
@ChenyuLInx ChenyuLInx mentioned this issue Oct 27, 2023
Merged
5 tasks
@dbeatty10 dbeatty10 mentioned this issue Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChenyuLInx ChenyuLInx

Labels
backport 1.7.latest enhancement New feature or request Impact: SL user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add a no-op runner for saved_query dbt-labs/dbt-core
2 participants
@ChenyuLInx @graciegoheen