Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3206] Add warning_tag to UnversionedBreakingChange #8827

Closed
Tracked by #7979
jtcohen6 opened this issue Oct 11, 2023 · 0 comments · Fixed by #8828
Closed
Tracked by #7979

[CT-3206] Add warning_tag to UnversionedBreakingChange #8827

jtcohen6 opened this issue Oct 11, 2023 · 0 comments · Fixed by #8828

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Oct 11, 2023

follow-up to #8384

I would like UnversionedBreakingChange to be flagged as a "warning" in CI:

Screenshot 2023-10-11 at 16 34 46

Right now, that should be as simple as adding a warning_tag to UnversionedBreakingChange

For later: We are inconsistent about the application of warning_tag to the formatted messages of WarnLevel events. Probably this should be more consistent, and maybe handled within the EventManager (instead of each event class individually). That's for later.

@github-actions github-actions bot changed the title Add warning_tag to UnversionedBreakingChange [CT-3206] Add warning_tag to UnversionedBreakingChange Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant