-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-3175] Convert print
call sites to logging events
#8756
Comments
print
call sites to logging eventsprint
call sites to logging events
@jtcohen6 if I understand correctly, this also affects the python CLI? I've been trying to suppress the output of the below command but it seems to ignore the
|
Relates to #10030 |
We should consider deprecating the jinja |
Note: This may also close #9174 |
There is one potential complication with the |
@peterallenwebb You're right about the need to hide timestamps. We suggest that users who wish to hide unrelated lines use Could you imagine adding logic within the EventManager such that:
@dbeatty10 has another good related proposal, which is that |
Housekeeping
Short description
There are two places where we currently call
print
, and should instead fire events. The reason these callprint
is that we don't want them to include timestamps or other formatting additions when sent to stdout. This enables easy copy-paste or piping to file/jq/etc.print
Jinja context method (source, docs). Convert to a newUserPrint
event.dbt list
with non-JSON logging (source). Convert to existingListCmdOut
event.We also need a new behavior for the text + stdout logger (and only the combination of text + stdout). We should skip adding formatting (including timestamp/spacing) for the
UserPrint
+ListOutput
events.Acceptance criteria
print
method withindbt-core
codebaseImpact to Other Teams
print
UserPrint
+ListOutput
eventsWill backports be required?
Let's just fix this going forward
Context
print
#6543The text was updated successfully, but these errors were encountered: