[CT-3145] [Bug] partial parsing issue when adding private models to a new group

[dave-connors-3]

Is this a new bug in dbt-core?

• I believe this is a new bug in dbt-core
• I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

loom explanation

adding multiple nodes that have a relationships to the same group with private access results in a parsing error:

Parsing Error
  Node model.mega_corp_big_co_inc.int_returns__unioned attempted to reference node model.mega_corp_big_co_inc.stg_tpcds_core__catalog_returns, which is not allowed because the referenced node is private to the 'sales_analytics' group.

in this case, int_returns__unioned is a child of stg_tpcds_core__catalog_returns, both were added to a newly-created group called sales_analytics and had access set to private, all of which happened between invocations of dbt.

Expected Behavior

everything should parse just fine! these are both private members of the same group and we love that

Steps To Reproduce

see loom!

Relevant log output

No response

Environment

- OS: mac
- Python: Python 3.9.16
- dbt: 1.6.0 and 1.6.3 (see loom)

Which database adapter are you using with dbt?

snowflake

Additional Context

i love dbt

[dbeatty10]

Reprex (using the Loom as inspiration)

models/my_model_a

select 1 as id

models/my_model_b

select 2 as id

models/my_model_c

select * from {{ ref("my_model_a") }} union all
select * from {{ ref("my_model_b") }}

models/_models.yml

models:
  - name: my_model_a
  - name: my_model_b
  - name: my_model_c

Clean out any previous artifacts and compile in that fresh environment (everything should work fine):

dbt clean
dbt compile

Now update your models/_models.yml file like this:

groups:
  - name: sales_analytics
    owner:
      name: Sales Analytics
      email: [email protected]

models:
  - name: my_model_a
    access: private
    group: sales_analytics
  - name: my_model_b
    access: private
    group: sales_analytics
  - name: my_model_c
    access: private
    group: sales_analytics

Doing this will yield an error:

dbt compile

But doing this instead would have not yielded an error:

dbt --no-partial-parse compile

Either way, re-running this command a 2nd time worked for me:

dbt compile

[gshank]

This particular bug shouldn't happen in 1.5, so I'm removing the backport 1.5.latest label.

[gshank]

This went out in 1.7 already, so it doesn't need backporting to 1.7.