Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3090] Support properties for null value coalescing in metrics #8593

Closed
Tracked by #8125
QMalcolm opened this issue Sep 8, 2023 · 0 comments · Fixed by #8700
Closed
Tracked by #8125

[CT-3090] Support properties for null value coalescing in metrics #8593

QMalcolm opened this issue Sep 8, 2023 · 0 comments · Fixed by #8700
Assignees
Labels
backport 1.6.latest bug Something isn't working Impact: CA semantic Issues related to the semantic layer

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Sep 8, 2023

Details

It was raised in MetricFlow recently that null values aren't always handled gracefully (dbt-labs/metricflow#764). The proposed solution (dbt-labs/metricflow#759) requires some changes to the Metric sub protocols as define in the dbt-semantic-interfaces issue (dbt-labs/dbt-semantic-interfaces#142). Once the changes have been made in dbt-semantic-interfaces, we'll want to update our implementation of the affected protocol and the associated parsing logic (unparsed definition, schema_yaml_reader)

Acceptance Criteria

  • People can specify join_to_timespine boolean value in their metric type params measure inputs
    • If not specified, default to False
  • People can specify fill_nulls_with integer value in their metric type params measure inputs
    • If not specified, default to None
  • join_to_timespine and fill_nulls_with are propagated to semantic_manifest.json

Blocked By

dbt-labs/dbt-semantic-interfaces#142

Backport

The issue in DSI will be backported to DSI 0.2.latest and that will allow for backporting to dbt-core 1.6.latest.

@github-actions github-actions bot changed the title Support properties for null value coalescing in metrics [CT-3090] Support properties for null value coalescing in metrics Sep 8, 2023
@QMalcolm QMalcolm added semantic Issues related to the semantic layer backport 1.6.latest bug Something isn't working labels Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.6.latest bug Something isn't working Impact: CA semantic Issues related to the semantic layer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants