Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2921] Create special unit testing Config object #8294

Closed
Tracked by #8283
gshank opened this issue Aug 2, 2023 · 2 comments
Closed
Tracked by #8283

[CT-2921] Create special unit testing Config object #8294

gshank opened this issue Aug 2, 2023 · 2 comments
Assignees

Comments

@gshank
Copy link
Contributor

gshank commented Aug 2, 2023

The initial unit testing branch specifies TestConfig in model_config.py, but actually uses NodeConfig (from ParsedNode) in the UnitTestNode. Make a custom UnitTestConfig with appropriate fields and use in UnitTestNode.

Is this actually required? We're now selecting against standard model nodes, and the database/schema/identifier is also coming from the model nodes. So it's not clear what we would need from a specialized Config object.

@github-actions github-actions bot changed the title Create special unit testing Config object [CT-2921] Create special unit testing Config object Aug 2, 2023
@graciegoheen
Copy link
Contributor

Do we want to support these configs?

  • tags (test specific markers -> "flaky" "exclude")
  • meta (on every other resource type)

@MichelleArk
Copy link
Contributor

From refinement:

  • this config (supporting tags & meta to start) should support jinja rendering for consistency
  • this config should apply at the node-level (from schema.yml files) and also be configurable hierarchically from dbt_project.yml, with a new top-level unit block in dbt_project.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants