Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2916] Use a distinct flavor of Manifest, such as UnitTestManifest instead of base Manifest #8289

Closed
Tracked by #8283
gshank opened this issue Aug 2, 2023 · 1 comment

Comments

@gshank
Copy link
Contributor

gshank commented Aug 2, 2023

Description

In the initial unit testing branch we use a Manifest object to contain the special unit tests and mocked models. It might be better to use a different manifest class (like the MacroManifest), which could potentially contain extra methods for generating unit testing artifacts or results.

This is still worth experimenting with, but with some refactoring it feels like less of an issue, since we're now selecting against a standard manifest and writing the unit test manifest to a different file.

Acceptance Criteria

Unit testing manifest uses a special Manifest object

Impact to Other Teams

None

Will backports be required?

No

Context

@github-actions github-actions bot changed the title Use a distinct flavor of Manifest, such as UnitTestManifest instead of base Manifest [CT-2916] Use a distinct flavor of Manifest, such as UnitTestManifest instead of base Manifest Aug 2, 2023
@graciegoheen
Copy link
Contributor

We need to think about how this metadata becomes available when you are and are not actually running unit tests (e.g. can we still get metadata about unit tests in production when you're not running unit tests in production).

@graciegoheen graciegoheen closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants