Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2870] [Bug] Incorrect examples in docker README #8211

Closed
2 tasks done
jamezrin opened this issue Jul 26, 2023 · 0 comments · Fixed by #8212
Closed
2 tasks done

[CT-2870] [Bug] Incorrect examples in docker README #8211

jamezrin opened this issue Jul 26, 2023 · 0 comments · Fixed by #8212
Labels
bug Something isn't working docker Related to official Docker files/images for dbt

Comments

@jamezrin
Copy link
Contributor

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

The README file located in the directory for the Dockerfile has incorrect commands and inconsistent spacing between arguments.

  • The command indicated in "Running an image in a container" is missing a newline escape
  • There are two whitespaces before the --target flag in the examples and between other parameters
  • Markdown script end markers are indented wrong
  • Unnecessary newline escapes in two of the commands suggested

Expected Behavior

The README should provide commands that are functional and the style for the shell script should be consistent within the README file.

Steps To Reproduce

For example, execute the command for "Running an image in a container" as indicated by the README file

Relevant log output

N/A

Environment

N/A

Which database adapter are you using with dbt?

No response

Additional Context

No response

@jamezrin jamezrin added bug Something isn't working triage labels Jul 26, 2023
@github-actions github-actions bot changed the title [Bug] Incorrect examples in docker README [CT-2870] [Bug] Incorrect examples in docker README Jul 26, 2023
@dbeatty10 dbeatty10 added docker Related to official Docker files/images for dbt and removed triage labels Jul 26, 2023
@dbeatty10 dbeatty10 removed their assignment Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docker Related to official Docker files/images for dbt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants