Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-2837] Stop skipping test_expression_metric #8134

Closed
Tracked by #8125
QMalcolm opened this issue Jul 18, 2023 · 0 comments · Fixed by #8578
Closed
Tracked by #8125

[CT-2837] Stop skipping test_expression_metric #8134

QMalcolm opened this issue Jul 18, 2023 · 0 comments · Fixed by #8578
Assignees
@QMalcolm
Labels
semantic Issues related to the semantic layer tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@QMalcolm
Copy link
Contributor

We currently @pytest.mark.skip test_expression_metric. We should at this time be able to un-skip this test with some minor tweaks. Additionally, if the test is broken for real reasons, this issue should be converted to fixing the functionality as well.

Acceptance Criteria

  • test_expression_metric is no longer skipped
  • test_expression_metric renamed to test_derived_metric
  • test_derived_metric passes (and not because it's rigged)
@QMalcolm QMalcolm added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality semantic Issues related to the semantic layer labels Jul 18, 2023
@QMalcolm QMalcolm added this to the v1.7 milestone Jul 18, 2023
@github-actions github-actions bot changed the title [Tests] Stop skipping test_expression_metric [CT-2837] [Tests] Stop skipping test_expression_metric Jul 18, 2023
@QMalcolm QMalcolm mentioned this issue Jul 18, 2023
Closed
@QMalcolm QMalcolm changed the title [CT-2837] [Tests] Stop skipping test_expression_metric [CT-2837] Stop skipping test_expression_metric Jul 18, 2023
@QMalcolm QMalcolm mentioned this issue Jul 18, 2023
Closed
@jtcohen6 jtcohen6 removed this from the v1.7 milestone Jul 19, 2023
@QMalcolm QMalcolm mentioned this issue Sep 6, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QMalcolm QMalcolm

Labels
semantic Issues related to the semantic layer tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unskip and rename test_expression_metric dbt-labs/dbt-core
2 participants
@QMalcolm @jtcohen6