Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2812] Remove create_metric property from end user facing Measure spec #8064

Closed
Tracked by #7498
QMalcolm opened this issue Jul 10, 2023 · 2 comments · Fixed by #8068
Closed
Tracked by #7498

[CT-2812] Remove create_metric property from end user facing Measure spec #8064

QMalcolm opened this issue Jul 10, 2023 · 2 comments · Fixed by #8068
Labels
semantic Issues related to the semantic layer

Comments

@QMalcolm
Copy link
Contributor

Acceptance Criteria

Context

Currently we have create_metric property defined on the UnparsedMeasure for UnparsedSemanticModels. The create_metric property is incredibly useful, if it were hooked up. However, we haven't hooked it up, and don't have time to do so before the 1.6.0rc release of core. Thus, for 1.6.x of core we shouldn't allow users to specify this property.

@QMalcolm QMalcolm added the semantic Issues related to the semantic layer label Jul 10, 2023
@QMalcolm QMalcolm added this to the v1.6 milestone Jul 10, 2023
@github-actions github-actions bot changed the title Remove create_metric property from end user facing Measure spec [CT-2812] Remove create_metric property from end user facing Measure spec Jul 10, 2023
@jtcohen6
Copy link
Contributor

@QMalcolm Is this something we need to do before cutting the v1.6 RC on Thursday? The alternative seems like: leave it in place for now, knowing that we're planning to add in support for this in v1.7

@QMalcolm
Copy link
Contributor Author

@jtcohen6 I think we don't want to allow users to specify it. It can be something that remains on the graph node, but should be removed from the unparsed version of the node. It's a two line change

@jtcohen6 jtcohen6 removed this from the v1.6 milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semantic Issues related to the semantic layer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants