Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-2639] Split out long partial parsing integration tests into smaller pieces #7786

Open
MichelleArk opened this issue Jun 5, 2023 · 1 comment
Open

[CT-2639] Split out long partial parsing integration tests into smaller pieces #7786

MichelleArk opened this issue Jun 5, 2023 · 1 comment
Labels
repo ci/cd Testing and continuous integration for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@MichelleArk
Copy link
Contributor

MichelleArk commented Jun 5, 2023 •
edited by martynydbt
Loading

Acceptance:

No meaningful impact to test run time.
Split tests into additional files based on classes (break into more classes)

Context:

Example: test_pp_models have ~30 assertions (160 lines)

@gshank the "test_partial_parsing" file is getting pretty long. Might be a good idea to split it up into smaller pieces. But probably not for this pull request. Maybe we should open another ticket...

@MichelleArk Splitting out some of the longer tests into their own pieces would help for debugging / understanding coverage / readability.

Originally posted by @MichelleArk in #7783 (comment)
@github-actions github-actions bot changed the title Split out long partial parsing integration tests into smaller pieces [CT-2639] Split out long partial parsing integration tests into smaller pieces Jun 5, 2023
@MichelleArk MichelleArk added the tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality label Jun 5, 2023
@MichelleArk MichelleArk mentioned this issue Jun 5, 2023
Merged
6 tasks
@jtcohen6 jtcohen6 added the repo ci/cd Testing and continuous integration for dbt-core + adapter plugins label Jun 12, 2023
@graciegoheen
Copy link
Contributor

graciegoheen commented Aug 21, 2023 •
edited
Loading

Notes from refinement:

  • the tests themselves are very long, do we want to break them into separate tests? could impact performance of test execution
  • do we want them in separate files? there may be some benefits of doing it this way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
repo ci/cd Testing and continuous integration for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MichelleArk @jtcohen6 @graciegoheen