You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As part of the work for clone #7256, reffable nodes need to hold a reference to their "other" counterparts in other schemas.
Jeremy already has a draft PR up that accomplishes this and uses the name "state_relation" as seen in the links below, however we are not beholden to this name.
As always, the language team has the final say in all things artifacts so make sure to get their sign off on whatever approach is taken.
Dependencies
Adapter work from #7549 will be dependent on the work in this ticket.
Acceptance Criteria
The reffable node classes (i.e. ModelNode, SeedNode, and SnapshotNode) have a field that stores a relation to an "other" counterpart in another schema
This new attribute is not written to manifest.json
This new attribute is somehow tested
Links from the draft PR
Separating RelationalNode from ParsedNodeMandatory:
github-actionsbot
changed the title
Add relation attribute to reffable node classes
[CT-2544] Add relation attribute to reffable node classes
May 8, 2023
stu-k
changed the title
[CT-2544] Add relation attribute to reffable node classes
[CT-2544] Add "other" relation attribute to reffable node classes
May 8, 2023
Description
As part of the work for clone #7256, reffable nodes need to hold a reference to their "other" counterparts in other schemas.
Jeremy already has a draft PR up that accomplishes this and uses the name
"state_relation"
as seen in the links below, however we are not beholden to this name.As always, the language team has the final say in all things artifacts so make sure to get their sign off on whatever approach is taken.
Dependencies
Adapter work from #7549 will be dependent on the work in this ticket.
Acceptance Criteria
ModelNode
,SeedNode
, andSnapshotNode
) have a field that stores a relation to an "other" counterpart in another schemamanifest.json
Links from the draft PR
Separating
RelationalNode
fromParsedNodeMandatory
:dbt-core/core/dbt/contracts/graph/nodes.py
Lines 231 to 243 in 5f08d70
Adding a relation to a reffable node:
dbt-core/core/dbt/contracts/graph/nodes.py
Lines 570 to 574 in 5f08d70
Serializing the new relation attribute out of manifest writing:
dbt-core/core/dbt/contracts/graph/manifest.py
Lines 1256 to 1262 in 5f08d70
Adding the new relation attribute to required node keys for manifest tests:
dbt-core/test/unit/test_manifest.py
Lines 91 to 92 in 5f08d70
The text was updated successfully, but these errors were encountered: