Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2470] Package-namespaced macro resolution #7444

Closed
Tracked by #7372
MichelleArk opened this issue Apr 24, 2023 · 0 comments · Fixed by #7509
Closed
Tracked by #7372

[CT-2470] Package-namespaced macro resolution #7444

MichelleArk opened this issue Apr 24, 2023 · 0 comments · Fixed by #7509
Assignees

Comments

@MichelleArk
Copy link
Contributor

MichelleArk commented Apr 24, 2023

Resources in a package should be rendered with a rendering context specific to that package (its vars and macros). This issue focuses on macros resolution.

Acceptance Criteria

  • Macros defined in imported packages should be respected when compiling code defined in same imported package (this is already the case - just not for generate_x_macros)

  • MacroManifest.find_generate_macro_by_name should consider imported packages if the calling node is defined in an imported package:

    The `generate_X_name` macros are similar to regular ones, but ignore
    imported packages.

    • e.g. package_a uses its version of get_custom_alias, package_b uses its version of get_custom_alias during parse-time
  • If the root project wants to override a package_a macro being called within a package_a model, it would be possible to achieve this desirable behavior with dispatch — as long as the package_a macro in question is dispatched to the package_a namespace.

@MichelleArk MichelleArk added Refinement Maintainer input needed multi_project labels Apr 24, 2023
@MichelleArk MichelleArk self-assigned this Apr 24, 2023
@github-actions github-actions bot changed the title Package-namespaced macro resolution [CT-2470] Package-namespaced macro resolution Apr 24, 2023
@MichelleArk MichelleArk removed the Refinement Maintainer input needed label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant