Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2425] [Bug] Not able to set quiet: true in profiles.yml #7378

Closed
2 tasks done
dbeatty10 opened this issue Apr 17, 2023 · 3 comments
Closed
2 tasks done

[CT-2425] [Bug] Not able to set quiet: true in profiles.yml #7378

dbeatty10 opened this issue Apr 17, 2023 · 3 comments
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists user docs [docs.getdbt.com] Needs better documentation

Comments

@dbeatty10
Copy link
Contributor

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Configuring quiet: true in profiles.yml has no effect.

Searching within logs/dbt.log for a line that includes "running dbt with arguments" shows:

'quiet': 'False'

Side notes

Configuring log_cache_events: true also shows in the logs as:

'log_cache_events': 'False'

Configuring introspect: false shows in the logs as:

'introspect': 'True'

Setting true/false booleans within profiles.yml for all the rest of the keys below do show up as expected within the logs (whether they are set to true or false):

The rest look good

All the rest of the keys in profiles.yml shown below seem to show the expected value within the logs/dbt.log (for both true or false):

profiles.yml

config:
  write_json: true
  partial_parse: true
  cache_selected_only: true
  version_check: true
  fail_fast: true
  debug: true
  warn_error: true
  use_colors: true
  use_experimental_parser: true
  no_print: true
  static_parser: true
  send_anonymous_usage_stats: true

Expected Behavior

That configuring quiet: true in profiles.yml works just as well as -q or --quiet or the DBT_QUIET environment variable as described here:
https://docs.getdbt.com/reference/global-configs#suppress-non-error-logs-in-output

profiles.yml

config:
  quiet: true

If this is expected to be invalid within profiles.yml, then remove that section of the documentation on docs.getdbt.com.
☝️ I'm guessing updating the documentation is the thing to do, because I couldn't get it to work for any version of dbt between 1.0 and 1.5. I didn't try anything earlier than 1.0.

Steps To Reproduce

  1. dbt ls - to establish a baseline expectation
  2. Edit config portion of profiles.yml to include quiet: true
  3. dbt ls - see that it does the same thing as before
  4. dbt --quiet ls - see that it does something different

Also search logs/dbt.log for "quiet" after each command to see its value.

Relevant log output

{
  "cache_selected_only": "True",
  "debug": "True",
  "fail_fast": "True",
  "indirect_selection": "eager",
  "introspect": "True",
  "log_cache_events": "False",
  "log_format": "default",
  "log_path": "/my_path/bug_quiet/logs",
  "no_print": "None",
  "partial_parse": "True",
  "printer_width": "80",
  "profiles_dir": "my_path/bug_quiet",
  "quiet": "False",
  "send_anonymous_usage_stats": "True",
  "static_parser": "True",
  "target_path": "None",
  "use_colors": "True",
  "use_experimental_parser": "True",
  "version_check": "True",
  "warn_error": "True",
  "warn_error_options": "WarnErrorOptions(include=[], exclude=[])",
  "write_json": "True"
}

Environment

- OS:
- Python:
- dbt: 1.5.0-rc1

Which database adapter are you using with dbt?

No response

Additional Context

No response

@dbeatty10 dbeatty10 added bug Something isn't working triage labels Apr 17, 2023
@github-actions github-actions bot changed the title [Bug] Not able to set quiet: true in profiles.yml [CT-2425] [Bug] Not able to set quiet: true in profiles.yml Apr 17, 2023
@dbeatty10
Copy link
Contributor Author

Could you take a look at this one @jtcohen6 ?

I suspect the "fix" will be just to remove this section of the docs:
https://docs.getdbt.com/reference/global-configs#suppress-non-error-logs-in-output

@jtcohen6
Copy link
Contributor

@dbeatty10 I'd like to fix this inconsistency!

(I don't even think it would be too tricky to do. Ideally, though, we'd come up with a way to define these parameters once rather than twice.)

We should definitely update the docs in the meantime, wherever there's a specific example that definitely doesn't work

@jtcohen6 jtcohen6 added user docs [docs.getdbt.com] Needs better documentation Team:Execution and removed triage labels Apr 17, 2023
@jtcohen6
Copy link
Contributor

I'm going to close this one in favor of #7036, which I've switched from tech_debt to bug, since there's real end-user-facing impact

@jtcohen6 jtcohen6 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2023
@jtcohen6 jtcohen6 added the duplicate This issue or pull request already exists label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

No branches or pull requests

2 participants