-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-2387] [Feature] Always write run_results.json
, even if --fail-fast
or unhandled error
#7302
Comments
run_results.json
, even if --fail-fast
or unhandled errorrun_results.json
, even if --fail-fast
or unhandled error
run_results.json
, even if --fail-fast
or unhandled errorrun_results.json
, even if --fail-fast
or unhandled error
@jtcohen6 We're going to point it based on the following assumptions:
|
@jtcohen6 Per BLG on 4/24-- It turns out that the original ticket (#3600) was fixed in some other PR between July of '21 and now. That said, a keyboard based process termination does still fail to write |
@iknox-fa Makes sense to me! |
As a consumer of dbt metadata, or a person who wants to "retry" a failed command (#7299), I need
run_results.json
to always be available at the end of a command.Currently,
run_results.json
is not written if:--fail-fast
, which has the effect of gracelessly terminating the process / cancelling nodes in other threads, as soon as one failure is encountered.Discussing with @ChenyuLInx, an answer that doesn't feel so terrible: write
run_results.json
after every node completes. That way, we don't need to gracefully handle graceless exits (whether due to--fail-fast
, keyboard interrupt, process termination...)Originally posted by @jtcohen6 in #3600 (comment)
The text was updated successfully, but these errors were encountered: