Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2020] [Bug] replace bump version dependency with bump2version #6845

Open
emmyoop opened this issue Feb 2, 2023 · 4 comments
Open

[CT-2020] [Bug] replace bump version dependency with bump2version #6845

emmyoop opened this issue Feb 2, 2023 · 4 comments
Labels
release Release processes for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@emmyoop
Copy link
Member

emmyoop commented Feb 2, 2023

Change Required

While everything still works, bumpversion has been abandoned and we should now use bump2version, which is what is being use under the hood anyways.

Listed as a dependency in dev-requirements.txt and used as part of the version bump. Will need to test this change against the release process, specifically the version bump piece. Will also require changes to the nightly release tests.

Needs to be done for all adapters as well.

Complication

We bump all version numbers that match, not just the expected current version. So we can inadvertently bump dependencies and break ourselves. Ideally we could list the current version in a single place and not multiple files. That would make it easier to bump.

@emmyoop emmyoop added bug Something isn't working triage labels Feb 2, 2023
@github-actions github-actions bot changed the title [Bug] replace bump version dependency with bump2version [CT-2020] [Bug] replace bump version dependency with bump2version Feb 2, 2023
@emmyoop emmyoop added the tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality label Feb 2, 2023
@dbeatty10
Copy link
Contributor

If we keep maintaining dbt-database-adapter-scaffold, then we should update here also.

@dbeatty10 dbeatty10 removed the triage label Feb 2, 2023
@jtcohen6 jtcohen6 added release Release processes for dbt-core + adapter plugins and removed bug Something isn't working labels Feb 3, 2023
@jtcohen6
Copy link
Contributor

jtcohen6 commented Feb 3, 2023

Estimated with @colin-rogers-dbt @McKnight-42. This is important, potential future blocker to successful release, we should try to knock it out before we get there. Not complex work but definitely some toil/tedium.

@emmyoop
Copy link
Member Author

emmyoop commented Feb 15, 2023

I'm not really sure what's going on with the project. There's a thread here on future ownership and the resolution still seems somewhat unclear. It might also be good to look at other alternatives.

@emmyoop
Copy link
Member Author

emmyoop commented Nov 16, 2023

bump2version is also abandoned now and recommends to move to bump-my-version.

bumpversion is the cause of a bug where anything that matches the current dbt version will also get bumped. See #9107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release processes for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

No branches or pull requests

3 participants